Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_synapse_spark_pool should support spark_version 3.3 #19854

Closed
1 task done
lestermarch opened this issue Jan 4, 2023 · 3 comments · Fixed by #19866
Closed
1 task done

azurerm_synapse_spark_pool should support spark_version 3.3 #19854

lestermarch opened this issue Jan 4, 2023 · 3 comments · Fixed by #19866

Comments

@lestermarch
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.3.3

AzureRM Provider Version

3.22.0

Affected Resource(s)/Data Source(s)

azurerm_synapse_spark_pool

Terraform Configuration Files

resource "azurerm_resource_group" "test" {
  name     = "rg-test"
  location = "UK South"
}

resource "azurerm_storage_account" "test" {
  name                            = "test20230104"
  resource_group_name             = azurerm_resource_group.test.name
  location                        = azurerm_resource_group.test.location
  account_tier                    = "Standard"
  account_replication_type        = "ZRS"
  account_kind                    = "StorageV2"
  default_to_oauth_authentication = true
  enable_https_traffic_only       = true
  is_hns_enabled                  = true
  min_tls_version                 = "TLS1_2"
  public_network_access_enabled   = true
}

resource "azurerm_storage_data_lake_gen2_filesystem" "test" {
  name               = "synapse"
  storage_account_id = azurerm_storage_account.test.id
}

resource "azurerm_synapse_workspace" "test" {
  name                                 = "test-workspace"
  resource_group_name                  = azurerm_resource_group.test.name
  location                             = azurerm_resource_group.test.location
  managed_resource_group_name          = "${azurerm_resource_group.test.name}-synapse-managed"
  managed_virtual_network_enabled      = true
  sql_administrator_login              = "test"
  sql_administrator_login_password     = "test"
  storage_data_lake_gen2_filesystem_id = azurerm_storage_data_lake_gen2_filesystem.test.id

  identity {
    type = "SystemAssigned"
  }
}

resource "azurerm_synapse_spark_pool" "synapse" {
  name                 = "testpool"
  synapse_workspace_id = azurerm_synapse_workspace.synapse.id
  node_size_family     = "MemoryOptimized"
  node_size            = "Small"
  spark_version        = "3.3"
}

Debug Output/Panic Output

╷
│ Error: expected spark_version to be one of [2.4 3.1 3.2], got 3.3
│ 
│   with module.synapse_workspace_private.azurerm_synapse_spark_pool.synapse[0],
│   on modules/synapse-workspace-private/synapse-spark-pool.tf line 8, in resource "azurerm_synapse_spark_pool" "synapse":
│    8:   spark_version        = var.spark_pool_version
│ 
╵
Releasing state lock. This may take a few moments...
##[error]Bash exited with code '1'.

Expected Behaviour

The provider should accept "3.3" as a valid value for spark_version.

Actual Behaviour

The provider only accepts "2.4", "3.1", or "3.2" as valid values for spark_version.

Steps to Reproduce

No response

Important Factoids

No response

References

Previous provider update to support Spark 3.2:
https://github.com/hashicorp/terraform-provider-azurerm/pull/16906/files

Microsoft documentation on Spark 3.3 availability:
https://learn.microsoft.com/en-us/azure/synapse-analytics/spark/apache-spark-33-runtime

@sinbai
Copy link
Contributor

sinbai commented Jan 5, 2023

@lestermarch thanks for opening this issue. PR has been submitted to support spark_version 3.3. Could you track it for more updates?

@github-actions github-actions bot added this to the v3.39.0 milestone Jan 9, 2023
@github-actions
Copy link

This functionality has been released in v3.39.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants