Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_lb_probe - Support property probe_threshold #19573

Merged
merged 2 commits into from
Dec 6, 2022
Merged

azurerm_lb_probe - Support property probe_threshold #19573

merged 2 commits into from
Dec 6, 2022

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Dec 6, 2022

Support property probe_threshold for resource azurerm_lb_probe.

Test Results:
PASS: TestAccAzureRMLoadBalancerProbe_basic (391.24s)
PASS: TestAccAzureRMLoadBalancerProbe_update (478.81s)

stephybun
stephybun requested changes Dec 6, 2022
View reviewed changes
internal/services/loadbalancer/probe_resource.go Outdated
Comment on lines 139 to 141
if d.IsNewResource() {
log.Printf("is new resource")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some logic missing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephybun Thanks for reviewing. Just for testing. It has been removed.

stephybun
stephybun approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai LGTM 👍

@stephybun stephybun merged commit d9900da into hashicorp:main Dec 6, 2022
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 6, 2022
stephybun added a commit that referenced this pull request Dec 6, 2022
@stephybun
Update for #19573
1c41fad
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sinbai sinbai deleted the loadbalancer/enhancement_probe branch December 20, 2022 02:17
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@sinbai @favoretti
azurerm_lb_probe - Support property probe_threshold (hashicorp#19573
04318ab 
)

* support probe_threshold for azurerm_lb_probe

* update code
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@stephybun @favoretti
Update for hashicorp#19573
0b17080
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/load-balancers size/XS
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sinbai @stephybun