-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_iothub_x
- a state migration to work around the previously incorrect id casing
#19524
Conversation
…iously incorrect id casing
…sly incorrect id casing
…previously incorrect id casing
…y incorrect id casing
…d the previously incorrect id casing
… around the previously incorrect id casing
…around the previously incorrect id casing
…around the previously incorrect id casing
…he previously incorrect id casing
…viously incorrect id casing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mbfrahry, few minor comments, otherwise LGTM 👍
ForceNew: true, | ||
}, | ||
|
||
"resource_group_name": commonschema.ResourceGroupName(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be good to in-line these in case the behaviour changes
// The condition is a string value representing device-to-cloud message routes query expression | ||
// https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-devguide-query-language#device-to-cloud-message-routes-query-expressions | ||
Type: pluginsdk.TypeString, | ||
Optional: true, | ||
Default: "true", | ||
}, | ||
|
||
"endpoint_names": { | ||
Type: pluginsdk.TypeList, | ||
Required: true, | ||
// Currently only one endpoint is allowed. With that comment from Microsoft, we'll leave this open to enhancement when they add multiple endpoint support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pedantic, but I think comments like these can be removed?
This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
We have an azurerm_eventgrid_event_subscription resource that takes an azurerm_iothub resource id as the scope. The change of IotHubs to iotHubs on the azurerm_iothub id is causing terraform to want to delete and create the azurerm_eventgrid_event_subscription. Did you miss a migration on the azurerm_eventgrid_event_subscription scope? |
…incorrect id casing (hashicorp#19524)
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.