Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_automation_webhook/azurerm_automation_source_control - a state migration to work around the previously incorrect id casing #19506

Merged
merged 5 commits into from
Dec 2, 2022
Merged

azurerm_automation_webhook/azurerm_automation_source_control - a state migration to work around the previously incorrect id casing #19506

merged 5 commits into from
Dec 2, 2022

Conversation

mbfrahry
Copy link
Member

No description provided.

@github-actions github-actions bot added size/XL and removed size/L labels Nov 30, 2022
@mbfrahry mbfrahry changed the title azurerm_automation_webhook - a state migration to work around the previously incorrect id casing azurerm_automation_webhook/azurerm_automation_source_control - a state migration to work around the previously incorrect id casing Nov 30, 2022
stephybun
stephybun approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry, file names have typos but otherwise LGTM 👍

internal/services/automation/migration/automation_source_control_migraiton_v0_to_v1.go Outdated
@@ -0,0 +1,104 @@
package migration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name has a typo migraiton -> migration

internal/services/automation/migration/automation_webhook_migraiton_v0_to_v1.go Outdated
@@ -0,0 +1,82 @@
package migration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@mbfrahry mbfrahry added this to the v3.35.0 milestone Dec 2, 2022
@mbfrahry mbfrahry merged commit 82597ef into main Dec 2, 2022
@mbfrahry mbfrahry deleted the sm-automation-webhook-id branch December 2, 2022 22:14
mbfrahry added a commit that referenced this pull request Dec 2, 2022
@mbfrahry
Update changelog for #19506
fa4a533
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation service/automation size/XL
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mbfrahry @stephybun