Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade managedservices.registrationdefinitions API version from 2019-06-01 to 2022-10-01 #19499

Merged

Conversation

neil-yechenwei
Copy link
Contributor

This PR is to upgrade managedservices.registrationdefinitions API version from 2019-06-01 to 2022-10-01.

Note: As the TCs related with Lighthouse Definition are skipped in Teamcity due to test data issue, so I ran them on my local and they passed.

--- PASS: TestAccLighthouseDefinition_basic (131.62s)
--- PASS: TestAccLighthouseDefinition_requiresImport (175.23s)
--- PASS: TestAccLighthouseDefinition_complete (161.23s)
--- PASS: TestAccLighthouseDefinition_update (559.91s)
--- PASS: TestAccLighthouseDefinition_emptyID (136.87s)
--- PASS: TestAccLighthouseDefinition_plan (127.90s)

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei Thanks for the update. I've run the tests locally and the import check for azurerm_lighthouse_assignment doesn't seem to be working. I'm not sure if this is a regression but could you take a look at this? Other than that, this should be good to merge.

Screen Shot 2022-12-01 at 20 45 59

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Dec 2, 2022

@manicminer , if you rollback to main branch, this TC still failed with same error. So I think this TC has failed for a long time not regression issue. As you can see, I didn't update the API version for LighthouseAssignment. I only updated the API version for LighthouseDefinition. Hence, I think this failed TC isn't related with this PR.

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Dec 2, 2022

@manicminer , after investigated, I found the root cause is that the logic of checking the existing resource is removed from this Lighthouse Assignment resource by this PR. So the test case failed. But per my understanding, it shouldn't be removed. So I updated this PR to add it back. Now all TCs passed.

--- PASS: TestAccLighthouseAssignment_basic (182.81s)
--- PASS: TestAccLighthouseAssignment_emptyID (190.43s)
--- PASS: TestAccLighthouseAssignment_requiresImport (223.70s)
--- PASS: TestAccLighthouseDefinition_emptyID (128.61s)
--- PASS: TestAccLighthouseDefinition_plan (132.03s)
--- PASS: TestAccLighthouseDefinition_basic (136.66s)
--- PASS: TestAccLighthouseDefinition_complete (149.70s)
--- PASS: TestAccLighthouseDefinition_requiresImport (168.46s)
--- PASS: TestAccLighthouseDefinition_update (532.46s)

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for spotting that and fixing @neil-yechenwei. Tests look good.

Screen Shot 2022-12-02 at 10 49 14

@manicminer manicminer merged commit 3a1268c into hashicorp:main Dec 2, 2022
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 2, 2022
manicminer added a commit that referenced this pull request Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants