Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Machine: Handling disk.ManagedDisk.ID being nil #1947

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Ensuring we nil-check ManagedDisk.ID before accessing it - which fixes #1941

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tombuildsstuff 👍

@tombuildsstuff tombuildsstuff merged commit 3bfc46e into master Sep 19, 2018
@tombuildsstuff tombuildsstuff deleted the disk-crash branch September 19, 2018 23:45
tombuildsstuff added a commit that referenced this pull request Sep 19, 2018
tombuildsstuff added a commit that referenced this pull request Sep 19, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform plan coredumps on new and old code
2 participants