Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resources: azurerm_dev_test_lab / azurerm_dev_test_virtual_network #1944

Merged
merged 10 commits into from
Sep 20, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Sep 19, 2018

This PR adds support for the DevTest Labs and DevTest Virtual Network resources.

There's a bug in the Azure API where the Resource Group name is being returned in lower-case (regardless of the input case) - so this PR currently ignores the casing on the Resource Group name field.

@tombuildsstuff
Copy link
Contributor Author

Resource tests pass:

screenshot 2018-09-20 at 09 51 54

@tombuildsstuff tombuildsstuff added this to the 1.16.0 milestone Sep 19, 2018
@tombuildsstuff
Copy link
Contributor Author

Data Source tests pass:

screenshot 2018-09-20 at 10 10 27

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff,

LGTM, left a few very minor comments inline but nothing I'd consider a blocker

azurerm/data_source_dev_test_lab.go Outdated Show resolved Hide resolved
azurerm/resource_arm_dev_test_lab.go Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor Author

Upstream API bug: Azure/azure-rest-api-specs#3964

@ghost ghost added the size/XXL label Sep 20, 2018
@tombuildsstuff tombuildsstuff merged commit 605042b into master Sep 20, 2018
@tombuildsstuff tombuildsstuff deleted the dev-test branch September 20, 2018 01:29
tombuildsstuff added a commit that referenced this pull request Sep 20, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants