Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_activity_log_alert - fix action webhook #19425

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Nov 24, 2022

resolves #19408

Change action block from TypeSet to TypeList. I think no need to use TypeSet here.

make acctests SERVICE="monitor" TESTARGS="-parallel 1 -test.run=TestAccMonitorActivityLogAlert_actionWebhook" TESTTIMEOUT='1440m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/monitor -parallel 1 -test.run=TestAccMonitorActivityLogAlert_actionWebhook -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMonitorActivityLogAlert_actionWebhook
=== PAUSE TestAccMonitorActivityLogAlert_actionWebhook
=== CONT  TestAccMonitorActivityLogAlert_actionWebhook
--- PASS: TestAccMonitorActivityLogAlert_actionWebhook (521.17s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor       522.369s

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @teowa
Can you add testing around multiple action blocks? The behaviour of the List vs Set won't be apparent with only 1 item, we'll need several to ensure that there are not ordering issues in the responses etc.

Thanks!

@teowa
Copy link
Contributor Author

teowa commented Nov 24, 2022

TF_ACC=1 go test -v ./internal/services/monitor -parallel 1 -test.run=TestAccMonitorActivityLogAlert_actionWebhook -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMonitorActivityLogAlert_actionWebhook
=== PAUSE TestAccMonitorActivityLogAlert_actionWebhook
=== CONT  TestAccMonitorActivityLogAlert_actionWebhook
--- PASS: TestAccMonitorActivityLogAlert_actionWebhook (353.24s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor       354.404s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa, LGTM 🌵

@stephybun stephybun merged commit 12ddbbc into hashicorp:main Nov 28, 2022
@github-actions github-actions bot added this to the v3.34.0 milestone Nov 28, 2022
stephybun added a commit that referenced this pull request Nov 28, 2022
harshavmb pushed a commit to AmadeusITGroup/terraform-provider-azurerm that referenced this pull request Nov 28, 2022
…19425)

* change action to list

* fix activity log alert action webhook

* add action block in test
harshavmb pushed a commit to AmadeusITGroup/terraform-provider-azurerm that referenced this pull request Nov 28, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This functionality has been released in v3.34.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webhook_properties are not picked up as changes in the azurerm_monitor_activity_log_alert
3 participants