Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_private_endpoint - add member_name property of ip_configuration block, support multiple ip_configuration blocks. #19389

Merged
merged 5 commits into from
Dec 12, 2022

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Nov 22, 2022

fix #19293
fix #18443

CI failed due to a lock on subnet used on delete function added #16315, and it cannot be resolved for now.

Screenshot 2022-11-22 at 16 12 04

…uration` block, support multiple `ip_configuration` blocks.
@ziyeqf ziyeqf force-pushed the tengzh/issue/private_endpoint_multi_ip branch from cf08ff7 to 5389c51 Compare November 22, 2022 07:22
@ziyeqf ziyeqf marked this pull request as ready for review November 22, 2022 08:12
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ziyeqf - LGTM 🦘

@katbyte katbyte merged commit 0b3241f into hashicorp:main Dec 12, 2022
katbyte added a commit that referenced this pull request Dec 12, 2022
@ziyeqf ziyeqf deleted the tengzh/issue/private_endpoint_multi_ip branch December 12, 2022 07:18
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants