Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_cdn_frontdoor_rule - allow cache_duration to be null if cache_behavior is set to HonorOrigin #19378

Merged
merged 2 commits into from
Nov 23, 2022
Merged

azurerm_cdn_frontdoor_rule - allow cache_duration to be null if cache_behavior is set to HonorOrigin #19378

merged 2 commits into from
Nov 23, 2022

Conversation

WodansSon
Copy link
Collaborator

(fixes #19311)

@WodansSon WodansSon added this to the v3.33.0 milestone Nov 21, 2022
@WodansSon WodansSon marked this pull request as draft November 21, 2022 23:15
@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon marked this pull request as ready for review November 22, 2022 00:31
@mbfrahry mbfrahry changed the title [Bug:] azurerm_cdn_frontdoor_rule - allow cache_duration to be null if cache_behavior is set to HonorOrigin azurerm_cdn_frontdoor_rule - allow cache_duration to be null if cache_behavior is set to HonorOrigin Nov 23, 2022
mbfrahry
mbfrahry approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbfrahry mbfrahry merged commit ea5ed67 into main Nov 23, 2022
@mbfrahry mbfrahry deleted the b_cdn_frontdoor_rule_honor_origin branch November 23, 2022 04:14
mbfrahry added a commit that referenced this pull request Nov 23, 2022
@mbfrahry
Update changelog for #19378
52cb1b7
@github-actions
Copy link

This functionality has been released in v3.33.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
bug service/cdn size/M
Projects
None yet
Milestone
v3.33.0
Development

Successfully merging this pull request may close these issues.

Frontdoor rule not accepting cache_duration null value
2 participants
@WodansSon @mbfrahry