Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source:] azurerm_cdn_frontdoor_custom_domain #19357

Merged
merged 6 commits into from
Nov 19, 2022

Conversation

WodansSon
Copy link
Collaborator

(fixes #19296)

@WodansSon
Copy link
Collaborator Author

image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments inline but this otherwise LGTM 👍

Comment on lines +6 to +65
Gets information about an existing Front Door (standard/premium) Custom Domain.
---

# Data Source: azurerm_cdn_frontdoor_custom_domain

Use this data source to access information about an existing Front Door (standard/premium) Custom Domain.

## Example Usage

```hcl
data "azurerm_cdn_frontdoor_custom_domain" "example" {
name = azurerm_cdn_frontdoor_custom_domain.example.name
profile_name = azurerm_cdn_frontdoor_profile.example.name
resource_group_name = azurerm_cdn_frontdoor_profile.example.resource_group_name
}
```

## Arguments Reference

The following arguments are supported:

* `name` - (Required) The name of the Front Door Custom Domain.

* `profile_name` - (Required) The name of the Front Door Profile which the Front Door Custom Domain is bound to.

* `resource_group_name` - (Required) The name of the Resource Group where the Front Door Profile exists.

## Attributes Reference

In addition to the Arguments listed above - the following Attributes are exported:

* `id` - The ID of the Front Door Custom Domain.

* `cdn_frontdoor_profile_id` - The ID of the Front Door Profile which the Front Door Custom Domain is bound to.

* `expiration_date` - The date time that the token expires.

* `host_name` - The host name of the domain.

* `tls` - A `tls` block as defined below.

* `validation_token` - The challenge used for DNS TXT record or file based validation.

---

A `tls` block exports the following:

* `cdn_frontdoor_secret_id` - The Resource ID of the Front Door Secret.

* `certificate_type` - The SSL certificate type.

* `minimum_tls_version` - The TLS protocol version that will be used for Https connections.

---

## Timeouts

The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/docs/configuration/resources.html#timeouts) for certain actions:

* `read` - (Defaults to 5 minutes) Used when retrieving the Front Door Custom Domain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be CDN Front Door?

Suggested change
Gets information about an existing Front Door (standard/premium) Custom Domain.
---
# Data Source: azurerm_cdn_frontdoor_custom_domain
Use this data source to access information about an existing Front Door (standard/premium) Custom Domain.
## Example Usage
```hcl
data "azurerm_cdn_frontdoor_custom_domain" "example" {
name = azurerm_cdn_frontdoor_custom_domain.example.name
profile_name = azurerm_cdn_frontdoor_profile.example.name
resource_group_name = azurerm_cdn_frontdoor_profile.example.resource_group_name
}
```
## Arguments Reference
The following arguments are supported:
* `name` - (Required) The name of the Front Door Custom Domain.
* `profile_name` - (Required) The name of the Front Door Profile which the Front Door Custom Domain is bound to.
* `resource_group_name` - (Required) The name of the Resource Group where the Front Door Profile exists.
## Attributes Reference
In addition to the Arguments listed above - the following Attributes are exported:
* `id` - The ID of the Front Door Custom Domain.
* `cdn_frontdoor_profile_id` - The ID of the Front Door Profile which the Front Door Custom Domain is bound to.
* `expiration_date` - The date time that the token expires.
* `host_name` - The host name of the domain.
* `tls` - A `tls` block as defined below.
* `validation_token` - The challenge used for DNS TXT record or file based validation.
---
A `tls` block exports the following:
* `cdn_frontdoor_secret_id` - The Resource ID of the Front Door Secret.
* `certificate_type` - The SSL certificate type.
* `minimum_tls_version` - The TLS protocol version that will be used for Https connections.
---
## Timeouts
The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/docs/configuration/resources.html#timeouts) for certain actions:
* `read` - (Defaults to 5 minutes) Used when retrieving the Front Door Custom Domain.
Gets information about an existing CDN Front Door (standard/premium) Custom Domain.
---
# Data Source: azurerm_cdn_frontdoor_custom_domain
Use this data source to access information about an existing CDN Front Door (standard/premium) Custom Domain.
## Example Usage
```hcl
data "azurerm_cdn_frontdoor_custom_domain" "example" {
name = azurerm_cdn_frontdoor_custom_domain.example.name
profile_name = azurerm_cdn_frontdoor_profile.example.name
resource_group_name = azurerm_cdn_frontdoor_profile.example.resource_group_name
}

Arguments Reference

The following arguments are supported:

  • name - (Required) The name of the CDN Front Door Custom Domain.

  • profile_name - (Required) The name of the CDN Front Door Profile which the Front Door Custom Domain is bound to.

  • resource_group_name - (Required) The name of the Resource Group where the CDN Front Door Profile exists.

Attributes Reference

In addition to the Arguments listed above - the following Attributes are exported:

  • id - The ID of the CDN Front Door Custom Domain.

  • cdn_frontdoor_profile_id - The ID of the CDN Front Door Profile which the CDN Front Door Custom Domain is bound to.

  • expiration_date - The date time that the token expires.

  • host_name - The host name of the domain.

  • tls - A tls block as defined below.

  • validation_token - The challenge used for DNS TXT record or file based validation.


A tls block exports the following:

  • cdn_frontdoor_secret_id - The ID of the CDN Front Door Secret.

  • certificate_type - The SSL certificate type.

  • minimum_tls_version - The TLS protocol version that will be used for HTTPS connections.


Timeouts

The timeouts block allows you to specify timeouts for certain actions:

  • read - (Defaults to 5 minutes) Used when retrieving the CDN Front Door Custom Domain.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That used to be true but we have changed all of the documentation to be Front Door (standard/premium) at the request of the service team. However, we did not change the resources, they are still cdn_frontdoor

@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit a362150 into main Nov 19, 2022
@WodansSon WodansSon deleted the nr_frontdoor_custom_domain_data branch November 19, 2022 05:48
WodansSon added a commit that referenced this pull request Nov 19, 2022
@github-actions
Copy link

This functionality has been released in v3.33.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data resource for azurerm_cdn_frontdoor_custom_domain
2 participants