Check if error is retryable before returning that it is

[carlpett]

Fixes #1757.

This PR checks if errors returned in resource_arm_role_assignment are actually retryable, rather than always retrying. If the approach is ok, it should also be applied to resource_arm_storage_container, which uses the same "always retry" logic.
Currently, I just check if the error (or nested error) is a *url.Error and if so if it is a temporary or timeout error. Anything else is deemed non-retryable. Are there other cases that should be retried?

[carlpett]

Also, this probably needs a test. Is the accepted way there to just write an acceptance test and push it and see if it works? I don't have an Azure account that I can/am allowed to run them on.

[katbyte]

Hi @carlpett,

Thank you for this fix. Might I suggest we move this to the utils/response package and create a new function ResponseErrorIsRetryable? I would also combine the switch and function here into this new call.

if err != nil {
  if utils.ResponseErrorIsRetryable(err) {
    return resource.RetryableError(err)
  } else {
    return resource.NonRetryableError(err)
  }
}

What do you think?

[carlpett]

Sure! I mostly threw it together without having too much insights into the repo at large, your suggestions look very good. Will push an update soon!
Regarding the acceptance tests, do you trigger them for PRs that look good?

[katbyte]

@carlpett,

Once the PR LGTM (or almost does) I will run the acceptance test internally for the entire resource. If you write an acceptance test it will be verified at that time.

[carlpett]

Pushed the implementation of your suggestions. I also noticed that net/url.Error is an implementation of net.Error, which covers a much wider range of errors, so I switched it out for that instead.

[katbyte]

Thanks for the updates @carlpett, LGTM 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!