Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service Plan: refactoring / handling errors in flatten functions #1926

Merged
merged 1 commit into from
Sep 23, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Noticed a couple of test failures we need more info to fix:

* azurerm_app_service_plan.test: web.AppServicePlansClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> <nil>

Ended up doing some crash fixes/set error handling when passing through too

@tombuildsstuff tombuildsstuff added this to the 1.16.0 milestone Sep 14, 2018
@tombuildsstuff tombuildsstuff requested a review from a team September 14, 2018 06:06
@ghost ghost added the size/M label Sep 14, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-09-24 at 06 54 07

@tombuildsstuff tombuildsstuff merged commit c3bdc0e into master Sep 23, 2018
@tombuildsstuff tombuildsstuff deleted the refactoring-appserviceplan branch September 23, 2018 20:55
tombuildsstuff added a commit that referenced this pull request Sep 23, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants