Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG:] azurerm_cdn_frontdoor_route - fix read function to parse cdn_frontdoor_origin_group_id insensitively #19178

Merged
merged 2 commits into from
Nov 9, 2022
Merged

[BUG:] azurerm_cdn_frontdoor_route - fix read function to parse cdn_frontdoor_origin_group_id insensitively #19178

merged 2 commits into from
Nov 9, 2022

Conversation

WodansSon
Copy link
Collaborator

(fixes #19103)

@github-actions github-actions bot added the size/M label Nov 7, 2022
@WodansSon WodansSon added this to the v3.31.0 milestone Nov 7, 2022
@WodansSon
Copy link
Collaborator Author

image

tombuildsstuff
tombuildsstuff suggested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment inline to fix up regarding the d.Id()

internal/services/cdn/cdn_frontdoor_route_resource.go Outdated Show resolved Hide resolved
katbyte
katbyte approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit 988d4b8 into main Nov 9, 2022
@WodansSon WodansSon deleted the b_frontdoor_read_casesensitivity branch November 9, 2022 22:14
WodansSon added a commit that referenced this pull request Nov 9, 2022
@WodansSon
updating to include #19178
33481ca
@github-actions
Copy link

This functionality has been released in v3.31.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
bug service/cdn size/M
Projects
None yet
Milestone
v3.31.0
Development

Successfully merging this pull request may close these issues.

Terraform keeps trying to change casing after importing azurerm_cdn_front_door_route
3 participants
@WodansSon @tombuildsstuff @katbyte