Expose ID of an embedded subnet defined in azurerm_virtual_network #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
suggested changes
Sep 12, 2018
There was a problem hiding this comment.
hey @JunyiYi
Thanks for this PR - if we can fix the documentation issues flagged below this otherwise LGTM 👍
Thanks!
tombuildsstuff
approved these changes
Sep 27, 2018
|
Tests pass (now that #1985 has been temporarily reverted):
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually it is hard to reference a specific subnet element in the current implementation because of the hash function. But that is a different story and requires state migration as well. So I just keep it as a small change in this PR.
The PR enables user referencing the subnet ID defined in
azurerm_virtual_networkresource mentioned in issue #666 .Fixes #666