azurerm_sentinel_alert_rule_fusion - support for sourceblock
#19093
Conversation
internal/services/sentinel/sentinel_alert_rule_fusion_resource.go
Outdated
Show resolved
Hide resolved
internal/services/sentinel/sentinel_alert_rule_fusion_resource.go
Outdated
Show resolved
Hide resolved
| Optional: true, | ||
| Default: true, | ||
| }, | ||
| "enabled_severities": { |
There was a problem hiding this comment.
should this be
| "enabled_severities": { | |
| "severities_enabled": { |
There was a problem hiding this comment.
@katbyte We used foo_enabled as a boolean property, whilst this one is an array of enabled severities.
There was a problem hiding this comment.
yes but putting it in front doesn't make sense. looking at the api closer, should this just be
| "enabled_severities": { | |
| "severities": { |
as it is the severities for this sub_type, so sub_type.enable = true means enable then, sub_type.enabled = false would actually disable them?
so maybe
| "enabled_severities": { | |
| "severities_allowed": { |
or
| "enabled_severities": { | |
| "severities_filter": { |
There was a problem hiding this comment.
@katbyte I see. I've renamed it to severities_allowed now.
|
@katbyte Properties are renamed, please take another look! |
| Optional: true, | ||
| Default: true, | ||
| }, | ||
| "enabled_severities": { |
There was a problem hiding this comment.
yes but putting it in front doesn't make sense. looking at the api closer, should this just be
| "enabled_severities": { | |
| "severities": { |
as it is the severities for this sub_type, so sub_type.enable = true means enable then, sub_type.enabled = false would actually disable them?
so maybe
| "enabled_severities": { | |
| "severities_allowed": { |
or
| "enabled_severities": { | |
| "severities_filter": { |
katbyte
changed the title
azurerm_sentinel_alert_rule_fusion - support for source_settingazurerm_sentinel_alert_rule_fusion - support for sourceblock
|
This functionality has been released in v3.31.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add new property
source_settingforazurerm_sentinel_alert_rule_fusion.In my first try, I've omit the
enabledproperties in the schema (see: 383de98). Due to the API issue Azure/azure-rest-api-specs#21387, it won't work.Test
💢 TF_ACC=1 go test -v -timeout=20h ./internal/services/sentinel -run=TestAccSentinelAlertRuleFusion_ === RUN TestAccSentinelAlertRuleFusion_basic === PAUSE TestAccSentinelAlertRuleFusion_basic === RUN TestAccSentinelAlertRuleFusion_disable === PAUSE TestAccSentinelAlertRuleFusion_disable === RUN TestAccSentinelAlertRuleFusion_sourceSetting === PAUSE TestAccSentinelAlertRuleFusion_sourceSetting === RUN TestAccSentinelAlertRuleFusion_requiresImport === PAUSE TestAccSentinelAlertRuleFusion_requiresImport === CONT TestAccSentinelAlertRuleFusion_basic === CONT TestAccSentinelAlertRuleFusion_sourceSetting === CONT TestAccSentinelAlertRuleFusion_requiresImport === CONT TestAccSentinelAlertRuleFusion_disable --- PASS: TestAccSentinelAlertRuleFusion_basic (185.42s) --- PASS: TestAccSentinelAlertRuleFusion_requiresImport (230.13s) --- PASS: TestAccSentinelAlertRuleFusion_sourceSetting (234.34s) --- PASS: TestAccSentinelAlertRuleFusion_disable (258.68s) PASS