ServiceBus Namespace: polling for the deletion #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WodansSon
approved these changes
Sep 11, 2018
katbyte
previously requested changes
Sep 11, 2018
| @@ -212,10 +213,19 @@ func resourceArmServiceBusNamespaceDelete(d *schema.ResourceData, meta interface | |||
| resourceGroup := id.ResourceGroup | |||
| name := id.Path["namespaces"] | |||
|
|
|||
| _, err = client.Delete(ctx, resourceGroup, name) | |||
| deleteFuture, err := client.Delete(ctx, resourceGroup, name) | |||
There was a problem hiding this comment.
could we call this future to match the rest of the codebase?
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| err = deleteFuture.WaitForCompletionRef(ctx, client.Client) | ||
| if err != nil { |
There was a problem hiding this comment.
These lines could be combines as such:
if err := deleteFuture.WaitForCompletionRef(ctx, client.Client); err != nil {| func testAccAzureRMServiceBusNamespace_premium(rInt int, location string) string { | ||
| return fmt.Sprintf(` | ||
| resource "azurerm_resource_group" "test" { | ||
| name = "acctestRG-%d" |
There was a problem hiding this comment.
Could we align these assignments?
| name = "acctestRG-%d" | ||
| location = "%s" | ||
| } | ||
| resource "azurerm_servicebus_namespace" "test" { |
There was a problem hiding this comment.
And add a space here between the resources
|
@katbyte Thanks for review, updated. |
|
Tests pass:
|
tombuildsstuff
changed the title
tombuildsstuff
changed the title
tombuildsstuff
added a commit
that referenced
this pull request
Sep 12, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting service bus in tanscation that resource group deletion will be blocked when sku set to premium.
Added WaitForCompletionRef method to make sure service bus was deleted and also added test for premium sku.
Thanks,
Chang