New resource: `azurerm_orbital_contact` #19036

jiaweitao001 · 2022-10-28T09:02:47Z

New resource to create a contact between ground stations and spacecrafts.
Acc tests are not runnable now. Due to restrictions of the service team, there're a few steps we need to follow to get the tests running.

Submit the Azure Orbital preview onboarding form.

Register a new spacecraft resource and make sure the spacecraft is authorized. Follow the steps here.

Paste the ID of the authorized spacecraft in the PR.

We will change the acc test accordingly after the spacecraft authorization to make sure they can run in team city.

katbyte

LGTM 📡 - just waiting on the service so we can test

jiaweitao001 · 2022-11-11T02:27:56Z

Hi @katbyte , just to make sure we are on the same page -- the steps I listed above in the comment are pending HashiCorp's action, it's because the authorized spacecraft must be created through your team's Azure Portal. If you have already submitted the request, please give us a heads up so we can catch up with the service team to see what we can do to enable the ACC tests. Thanks!

tombuildsstuff

hi @jiaweitao001

Thanks for this PR - I've taken a look through and left some comments inline, if we can fix those up then we should be able to take another look here.

Thanks!

tombuildsstuff · 2022-11-14T07:09:50Z

internal/services/orbital/contact_resource.go

+
+		"resource_group_name": azure.SchemaResourceGroupName(),
+
+		"spacecraft": {


is this the Spacecraft ID, if so, can we rename it that?

Suggested change

"spacecraft": {

"spacecraft_id": {

Sure. Renamed.

tombuildsstuff · 2022-11-14T07:10:09Z

internal/services/orbital/contact_resource.go

+			ValidateFunc: validation.StringIsNotEmpty,
+		},
+
+		"resource_group_name": azure.SchemaResourceGroupName(),


since the Spacecraft ID includes the Resource Group Name, we could remove this and infer it from the Spacecraft ID?

Right, removed.

tombuildsstuff · 2022-11-14T07:10:48Z

internal/services/orbital/contact_resource.go

+					ReservationStartTime: props.ReservationStartTime,
+					ReservationEndTime:   props.ReservationEndTime,
+					GroundStationName:    props.GroundStationName,
+					ContactProfileId:     *props.ContactProfile.Id,


this'll be a crash so we'll need to nil-check this

Added nil check.

tombuildsstuff · 2022-11-14T07:11:12Z

internal/services/orbital/contact_resource.go

+			if resp, err := client.Delete(ctx, *id); err != nil {
+				if !response.WasNotFound(resp.HttpResponse) {
+					return fmt.Errorf("deleting %s: %+v", *id, err)
+				}
+			}


this would indicate a bug so we should remove this:

Suggested change

if resp, err := client.Delete(ctx, *id); err != nil {

if !response.WasNotFound(resp.HttpResponse) {

return fmt.Errorf("deleting %s: %+v", *id, err)

}

}

if _, err := client.Delete(ctx, *id); err != nil {

return fmt.Errorf("deleting %s: %+v", *id, err)

}

katbyte

LGTM once tests pass 📡

katbyte

test failures:

jiaweitao001 · 2022-12-09T01:44:00Z

Hi @katbyte , could you please kindly paste the ID of the spacecraft created here? We will need to make a few modifications to ensure the acc tests can run with it.

katbyte · 2022-12-12T05:57:15Z

@jiaweitao001 - it should be in teamcity? either way the tests look like something unrelated to the service team?

------- Stdout: -------
=== RUN   TestAccContact_basic
=== PAUSE TestAccContact_basic
=== CONT  TestAccContact_basic
    testcase.go:110: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid resource type
        
          on terraform_plugin_test.tf line 93, in resource "azurerm_orbital_contact" "test":
          93: resource "azurerm_orbital_contact" "test" {
        
        The provider hashicorp/azurerm does not support resource type
        "azurerm_orbital_contact".
--- FAIL: TestAccContact_basic (3

------- Stdout: -------
=== RUN   TestAccContactProfile_basic
=== PAUSE TestAccContactProfile_basic
=== CONT  TestAccContactProfile_basic
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Subnet: (Name "testsubnet" / Virtual Network Name "testvnet" / Resource Group "acctestRG-221212000556754839"): network.SubnetsClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Code="InUseSubnetCannotBeDeleted" Message="Subnet testsubnet is in use by /subscriptions/*******/resourceGroups/acctestRG-221212000556754839/providers/Microsoft.Network/virtualNetworks/testvnet/subnets/testsubnet/serviceAssociationLinks/OrbitalManagedDNC and cannot be deleted. In order to delete the subnet, delete all the resources within the subnet. See aka.ms/deletesubnet." Details=[]
        
--- FAIL: TestAccContactProfile_basic (104.12s)
FAIL

catriona-m · 2022-12-14T10:17:53Z

Hi @jiaweitao001. Does this involve using the resource id of an authorised spacecraft? If so, would it make sense to have this input via an env var so anyone with an authorised spacecraft can run the tests?

katbyte · 2023-01-09T15:57:21Z

@jiaweitao001 - any updates on this one?

jiaweitao001 · 2023-01-10T01:43:10Z

Hi @catriona-m , as we discussed offline weeks ago, there's a request for registering a spacecraft submitted. Could you please check with the service team on how is that going? Thanks!

catriona-m · 2023-01-13T11:07:40Z

internal/services/orbital/contact_resource_test.go

@@ -55,7 +55,7 @@ func (r ContactResource) basic(data acceptance.TestData) string {
 resource "azurerm_orbital_contact" "test" {
  name                   = "testcontact-%[2]d"
  resource_group_name    = azurerm_resource_group.test.name
-  spacecraft_id          = azurerm_orbital_spacecraft.test.id
+  spacecraft_id          = "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/spaceymcspaceface/providers/Microsoft.Orbital/spacecrafts/spaceymcspaceface"


could we have this id as an env var that gets passed in instead? For example, like these tests have: https://github.com/hashicorp/terraform-provider-azurerm/blob/main/internal/services/bot/bot_channel_facebook_resource_test.go

jiaweitao001 · 2023-01-16T09:10:47Z

Tested with spacecraft owned by our team:

=== RUN   TestAccContact_basic
=== PAUSE TestAccContact_basic
=== CONT  TestAccContact_basic
--- PASS: TestAccContact_basic (313.60s)

catriona-m

Thanks for this @jiaweitao001. I've left a couple of minor comments inline but once those get fixed up we can take a look at merging this. Thanks!

internal/services/orbital/contact_resource_test.go

website/docs/r/orbital_contact.html.markdown

catriona-m

Thanks @jiaweitao001 this LGTM!

github-actions · 2023-01-27T04:28:37Z

This functionality has been released in v3.41.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-02-27T02:15:30Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New resource: azurerm_orbital_contact

1609059

github-actions bot added the documentation label Oct 28, 2022

fix docs

efb6bcb

katbyte approved these changes Nov 11, 2022

View reviewed changes

tombuildsstuff suggested changes Nov 14, 2022

View reviewed changes

github-actions bot added waiting-response size/XL and removed waiting-response labels Nov 14, 2022

Address comments

dd6ec01

jiaweitao001 force-pushed the orbital_contact_ground branch from 524baff to dd6ec01 Compare November 14, 2022 08:06

jiaweitao001 requested a review from tombuildsstuff November 15, 2022 01:59

katbyte approved these changes Dec 6, 2022

View reviewed changes

katbyte requested changes Dec 9, 2022

View reviewed changes

github-actions bot added the waiting-response label Dec 9, 2022

github-actions bot removed the waiting-response label Dec 9, 2022

katbyte added the waiting-response label Dec 12, 2022

github-actions bot removed the waiting-response label Jan 10, 2023

Update acc test parameter

aa97ca0

catriona-m reviewed Jan 13, 2023

View reviewed changes

github-actions bot added the waiting-response label Jan 13, 2023

Pass spacecraft id as an env variable

cfcae5e

github-actions bot removed the waiting-response label Jan 16, 2023

Update test

02de599

catriona-m requested changes Jan 16, 2023

View reviewed changes

internal/services/orbital/contact_resource_test.go Outdated Show resolved Hide resolved

internal/services/orbital/contact_resource_test.go Outdated Show resolved Hide resolved

website/docs/r/orbital_contact.html.markdown Outdated Show resolved Hide resolved

github-actions bot added the waiting-response label Jan 16, 2023

Update test and docs

d162f99

github-actions bot removed the waiting-response label Jan 17, 2023

catriona-m approved these changes Jan 24, 2023

View reviewed changes

katbyte merged commit bc1e094 into hashicorp:main Jan 26, 2023

katbyte added a commit that referenced this pull request Jan 26, 2023

CHANGELOG #19036

595a38a

github-actions bot added this to the v3.41.0 milestone Jan 26, 2023

github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: `azurerm_orbital_contact` #19036

New resource: `azurerm_orbital_contact` #19036

jiaweitao001 commented Oct 28, 2022

katbyte left a comment

jiaweitao001 commented Nov 11, 2022

tombuildsstuff left a comment

tombuildsstuff Nov 14, 2022

jiaweitao001 Nov 14, 2022

tombuildsstuff Nov 14, 2022

jiaweitao001 Nov 14, 2022

tombuildsstuff Nov 14, 2022

jiaweitao001 Nov 14, 2022

tombuildsstuff Nov 14, 2022

jiaweitao001 Nov 14, 2022

katbyte left a comment

katbyte left a comment

jiaweitao001 commented Dec 9, 2022

katbyte commented Dec 12, 2022

catriona-m commented Dec 14, 2022

katbyte commented Jan 9, 2023

jiaweitao001 commented Jan 10, 2023

catriona-m Jan 13, 2023

jiaweitao001 commented Jan 16, 2023

catriona-m left a comment

catriona-m left a comment

github-actions bot commented Jan 27, 2023

github-actions bot commented Feb 27, 2023


		"resource_group_name": azure.SchemaResourceGroupName(),

		"spacecraft": {

New resource: azurerm_orbital_contact #19036

New resource: azurerm_orbital_contact #19036

Conversation

jiaweitao001 commented Oct 28, 2022

katbyte left a comment

Choose a reason for hiding this comment

jiaweitao001 commented Nov 11, 2022

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

jiaweitao001 commented Dec 9, 2022

katbyte commented Dec 12, 2022

catriona-m commented Dec 14, 2022

katbyte commented Jan 9, 2023

jiaweitao001 commented Jan 10, 2023

Choose a reason for hiding this comment

jiaweitao001 commented Jan 16, 2023

catriona-m left a comment

Choose a reason for hiding this comment

catriona-m left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 27, 2023

github-actions bot commented Feb 27, 2023

New resource: `azurerm_orbital_contact` #19036

New resource: `azurerm_orbital_contact` #19036