Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_virtual_machine_scale_set azurerm_windows_virtual_machine_scale_set - rename gallery_applications #19014

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Oct 27, 2022

Renaming below properties according to #18406 (comment)
gallery_applications -> gallery_application
gallery_applications.package_reference_id -> gallery_application.version_id
gallery_applications.configuration_reference_blob_uri -> gallery_application.configuration_blob_uri

@myc2h6o myc2h6o changed the title azurerm_linux_virtual_machine_scale_set azurerm_windows_virtual_machine_scale_set - rename gally_applications azurerm_linux_virtual_machine_scale_set azurerm_windows_virtual_machine_scale_set - rename gallery_applications Oct 27, 2022
…chine_scale_set` - rename `gallery_applications`
@myc2h6o myc2h6o force-pushed the rename_vmss_gallery_app branch from df230c9 to ad588b6 Compare October 27, 2022 07:56
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for renaming these @myc2h6o - LGTM 🖥️

@katbyte katbyte merged commit 5126cc4 into hashicorp:main Oct 27, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 27, 2022
katbyte added a commit that referenced this pull request Oct 27, 2022
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@myc2h6o myc2h6o deleted the rename_vmss_gallery_app branch October 28, 2022 13:57
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants