Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_sentinel_data_connector_office_irm #18856

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Oct 19, 2022

Relating to #18195.

Test

💢  TF_ACC=1 go test -v -timeout=20h ./internal/services/sentinel -run='TestAccSentinelDataConnectorOfficeIRM_'
=== RUN   TestAccSentinelDataConnectorOfficeIRM_basic
=== PAUSE TestAccSentinelDataConnectorOfficeIRM_basic
=== RUN   TestAccSentinelDataConnectorOfficeIRM_complete
=== PAUSE TestAccSentinelDataConnectorOfficeIRM_complete
=== RUN   TestAccSentinelDataConnectorOfficeIRM_requiresImport
=== PAUSE TestAccSentinelDataConnectorOfficeIRM_requiresImport
=== CONT  TestAccSentinelDataConnectorOfficeIRM_basic
=== CONT  TestAccSentinelDataConnectorOfficeIRM_requiresImport
=== CONT  TestAccSentinelDataConnectorOfficeIRM_complete
--- PASS: TestAccSentinelDataConnectorOfficeIRM_basic (77.22s)
--- PASS: TestAccSentinelDataConnectorOfficeIRM_complete (81.19s)
--- PASS: TestAccSentinelDataConnectorOfficeIRM_requiresImport (150.87s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel      150.894s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @magodo LGTM 👍

Comment on lines +55 to +56
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This horizontal rule is a convetion for separating required and optional properties, which is introduced in the scaffold-website tool.

@stephybun stephybun merged commit 3747810 into hashicorp:main Oct 19, 2022
@github-actions github-actions bot added this to the v3.28.0 milestone Oct 19, 2022
stephybun added a commit that referenced this pull request Oct 19, 2022
@github-actions
Copy link

This functionality has been released in v3.28.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants