Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurem_logic_app_standard - support for scm_ip_restriction, scm_use_main_ip_restriction scm_min_tls_version scm_type #18853

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Oct 19, 2022

fix #18800

Test

TF_ACC=1 go test -v ./internal/services/logic -run=TestAccLogicAppStandard_scm -timeout=600m
=== RUN   TestAccLogicAppStandard_scmType
=== PAUSE TestAccLogicAppStandard_scmType
=== RUN   TestAccLogicAppStandard_scmUseMainIpRestriction
=== PAUSE TestAccLogicAppStandard_scmUseMainIpRestriction
=== RUN   TestAccLogicAppStandard_scmOneIpRestriction
=== PAUSE TestAccLogicAppStandard_scmOneIpRestriction
=== RUN   TestAccLogicAppStandard_scmMinTlsVersion
=== PAUSE TestAccLogicAppStandard_scmMinTlsVersion
=== CONT  TestAccLogicAppStandard_scmType
=== CONT  TestAccLogicAppStandard_scmOneIpRestriction
=== CONT  TestAccLogicAppStandard_scmUseMainIpRestriction
=== CONT  TestAccLogicAppStandard_scmMinTlsVersion
--- PASS: TestAccLogicAppStandard_scmOneIpRestriction (302.94s)
--- PASS: TestAccLogicAppStandard_scmMinTlsVersion (313.90s)
--- PASS: TestAccLogicAppStandard_scmType (318.64s)
--- PASS: TestAccLogicAppStandard_scmUseMainIpRestriction (503.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/logic504.247s

@ziyeqf ziyeqf changed the title Tengzh/issue/logic scm ip restriction 'azurem_logic_app_standard' - support for the scm related site config Oct 19, 2022
@ziyeqf ziyeqf changed the title 'azurem_logic_app_standard' - support for the scm related site config ‘azurem_logic_app_standard’ - support for the scm related site config Oct 19, 2022
@ziyeqf ziyeqf changed the title ‘azurem_logic_app_standard’ - support for the scm related site config azurem_logic_app_standard - support for the scm related site config Oct 19, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌋

@katbyte katbyte changed the title azurem_logic_app_standard - support for the scm related site config azurem_logic_app_standard - support for scm_ip_restriction, scm_use_main_ip_restriction scm_min_tls_version scm_type Oct 24, 2022
@katbyte katbyte merged commit b6202e7 into hashicorp:main Oct 24, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 24, 2022
katbyte added a commit that referenced this pull request Oct 24, 2022
@ziyeqf ziyeqf deleted the tengzh/issue/logic_scm_ip_restriction branch October 24, 2022 17:20
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants