Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to SDK v20.1.0 / Go-AutoRest v10.15.3 #1861

Merged
merged 6 commits into from
Sep 7, 2018

Conversation

tombuildsstuff
Copy link
Contributor

  • Upgrading to v20.1.0 of github.com/Azure/azure-sdk-for-go
  • Upgrading to v10.15.3 of github.com/Azure/go-autorest
  • Upgrading to 2018-06-01 of the Compute API

This is going to be required to unblock a fix needed in a future version of go-autorest and unblocks #1696

@tombuildsstuff tombuildsstuff added this to the 1.14.0 milestone Sep 4, 2018
@ghost ghost added the size/XXL label Sep 4, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.14.0, 1.15.0 Sep 6, 2018
@tombuildsstuff tombuildsstuff changed the title [WIP] Upgrading to SDK v20.1.0 / Go-AutoRest v10.15.3 Upgrading to SDK v20.1.0 / Go-AutoRest v10.15.3 Sep 6, 2018
@tombuildsstuff tombuildsstuff force-pushed the azure-sdk-20.1-autorest-10.15.3 branch from 6542816 to c8ac225 Compare September 6, 2018 18:46
@ghost ghost added the size/XXL label Sep 6, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff removed the request for review from katbyte September 7, 2018 08:03
@tombuildsstuff
Copy link
Contributor Author

Acceptance Tests look good 👍

@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants