azurerm_monitor_metric_alert - fix ordering of multi criteria

[teowa]

resolves #18410

Modify criteria and dynamic_criteria from TypeSet to TypeList, and add a testcase TestAccMonitorMetricAlert_multiCriteria.

Test Result:

[katbyte]

How come this needs to become a list? a set should ignore order?

[teowa]

We need keep criteria in order from TF config to API PUT request.
If using set, the criteria with demension will never in the first position of API PUT request, service returns error: In an alert rule with multiple criteria, if a criterion refers to a metric dimension that isn't available for a metric specified in other criteria, then that criterion has to be specified first in order

  criteria {
    metric_namespace = "Microsoft.Network/applicationGateways"
    metric_name      = "ApplicationGatewayTotalTime"
    aggregation      = "Average"
    operator         = "GreaterThan"
    threshold        = 1000
    dimension {
      name     = "Listener"
      operator = "Include"
      values   = ["sa-web-https"]
    }
  }

  criteria {
    metric_namespace = "Microsoft.Network/applicationGateways"
    metric_name      = "TotalRequests"
    aggregation      = "Total"
    operator         = "GreaterThan"
    threshold = 50000
  }

[katbyte]

Ahh that makes sense, thanks @teowa - LGTM ⚙️

[github-actions]

This functionality has been released in v3.24.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.