azurerm_kubernetes_cluster - making linux_profile optional
#1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AKS API does not require linux_profile to be set by default, this is enabled by default on Azure portal. Terraform's schema does not align with this, which causes importing issue.
Pass empty string to refactored function in import test of AKS.
Added the linux_profile configuration string while baking the configuration.
|
@zqingqing1 feel free to review it. |
metacpp
changed the title
|
lgtm |
Remove the basic test with linux profile to avoid string concat issue.
linux_profile needs to be computed since it's optional. Otherwise, return `terraform plan` will warn with change.
If the response of field is not returned in response body, need to return empty array.
|
Automation test result: |
tombuildsstuff
suggested changes
Aug 28, 2018
WodansSon
approved these changes
Aug 29, 2018
Add 2 tests to have more coverage on linuxProfile specific scenarios.
Removed useless linux_profile and kubernetes_version settings for tests.
Add newline to import test file for AKS.
Fix the path issue to correct naming for linux_profile.
|
Reran all 13 tests for AKS resource: |
tombuildsstuff
changed the title
azurerm_kubernetes_cluster - making linux_profile optional
tombuildsstuff
added a commit
that referenced
this pull request
Aug 30, 2018
torresdal
pushed a commit
to torresdal/terraform-provider-azurerm
that referenced
this pull request
Aug 31, 2018
`azurerm_kubernetes_cluster` - making `linux_profile` optional
torresdal
pushed a commit
to torresdal/terraform-provider-azurerm
that referenced
this pull request
Aug 31, 2018
jbcom
pushed a commit
to platonic-io/terraform-provider-azurerm
that referenced
this pull request
Sep 27, 2018
* timcurless/timcurless: Fixing issues with aadProfile server_app_secret always causing a new cluster Adding documentation updates Updating to include hashicorp#1845 Authentication: registering all clients consistently (hashicorp#1845) Updating to include hashicorp#1843 r/Logic App: ensuring parameters are strings prior to setting (hashicorp#1843) Updating to include hashicorp#1821 linux_profile should be optional to align with API spec (hashicorp#1821) Updating to include hashicorp#1816 Storage: Import Support (hashicorp#1816) Updating to include hashicorp#1835 Allow azurerm_function_app to use upper case names in consumption plan (hashicorp#1835) formatting
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to resolve the #1806.
The latest AKS API does not require linux_profile to be set, and Azure portal follows it. Terraform still requires it by default, this inconsistency caused the importing issue.
Manually created instance on Azure portal, and did
terraform importandterraform plan, no change is required.