Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for data source azurerm_monitor_data_collection_endpoint #17956

Closed
1 task done
nbjohnson opened this issue Aug 10, 2022 · 4 comments · Fixed by #17992
Closed
1 task done

Support for data source azurerm_monitor_data_collection_endpoint #17956

nbjohnson opened this issue Aug 10, 2022 · 4 comments · Fixed by #17992

Comments

@nbjohnson
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

A new resource azurerm_monitor_data_collection_endpoint was just added and now azurerm_monitor_data_collection_association is in the works and under review. To properly be able to use the data collection association I need the id of the data collection endpoint. Can a data source be added for azurerm_monitor_data_collection_endpoint so its id can easily be looked up?

New or Affected Resource(s)/Data Source(s)

azurerm_monitor_data_collection_endpoint

Potential Terraform Configuration

data "azurerm_monitor_data_collection_endpoint" "example" {
  resource_group_name = "terraform-example-rg"
  name                = "tf-dce"
}

output "data_collection_endpoint_id" {
  value = data.azurermr_monitor_data_collection_endpoint.example.id
}

References

#17831

https://docs.microsoft.com/en-us/rest/api/monitor/data-collection-endpoints/get?tabs=HTTP

@teowa
Copy link
Contributor

teowa commented Aug 11, 2022

@nbjohnson thanks for submiting this issue. I am going to work on this.🙂

@nbjohnson
Copy link
Author

@teowa Are you able to request a review for this PR and for your azurerm_monitor_data_collection_rule_association PR? I can't wait to see these merged in as they are exactly what is needed for me atm.

@teowa
Copy link
Contributor

teowa commented Aug 16, 2022

Thanks @nbjohnson for the comment. This pr is already in our review list, unfortunately, we may not be able to provide an ETA at the current moment. I'll keep a close eye on it and update you once there is a progress.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants