Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_cluster - update the validation for size_gb #17780

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

neil-yechenwei
Copy link
Contributor

This PR is to update the validation for size_gb.

--- PASS: TestAccLogAnalyticsCluster_resize (1932.09s)
--- PASS: TestAccLogAnalyticsCluster_basic (2118.79s)
--- PASS: TestAccLogAnalyticsCluster_requiresImport (2191.80s)

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei, thank you so much for this PR... the changes look mostly good to me but I have a few suggestions on the wording in the documentation. Can you take a look and let me know what you think? 🚀

website/docs/r/log_analytics_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/log_analytics_cluster.html.markdown Outdated Show resolved Hide resolved
@neil-yechenwei neil-yechenwei requested a review from WodansSon July 28, 2022 05:49
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei, thanks for pushing those changes... this LGTM! 🚀

@mybayern1974
Copy link
Collaborator

This PR fixes #17787

@niks-singh
Copy link

Can you please provide the version number in which this change will be available to use. I do not see this change in [v3.16.0] in registry

@tombuildsstuff tombuildsstuff modified the milestones: v3.16.0, v3.17.0 Jul 31, 2022
@stephybun stephybun force-pushed the loganakyticsclusterimprove branch from ded810c to cacb60c Compare August 2, 2022 07:03
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @neil-yechenwei and for the review @WodansSon. I went ahead and rebased this so that we can get this in, hope you don't mind.

@stephybun stephybun merged commit db73ba7 into hashicorp:main Aug 2, 2022
stephybun added a commit that referenced this pull request Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

This functionality has been released in v3.17.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants