-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_log_analytics_cluster - update the validation for size_gb #17780
azurerm_log_analytics_cluster - update the validation for size_gb #17780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neil-yechenwei, thank you so much for this PR... the changes look mostly good to me but I have a few suggestions on the wording in the documentation. Can you take a look and let me know what you think? 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neil-yechenwei, thanks for pushing those changes... this LGTM! 🚀
This PR fixes #17787 |
Can you please provide the version number in which this change will be available to use. I do not see this change in [v3.16.0] in registry |
ded810c
to
cacb60c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @neil-yechenwei and for the review @WodansSon. I went ahead and rebased this so that we can get this in, hope you don't mind.
This functionality has been released in v3.17.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR is to update the validation for
size_gb
.--- PASS: TestAccLogAnalyticsCluster_resize (1932.09s)
--- PASS: TestAccLogAnalyticsCluster_basic (2118.79s)
--- PASS: TestAccLogAnalyticsCluster_requiresImport (2191.80s)