azurerm_private_dns_zone - Ensure consistent ID generation

[owenfarrell]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Summary

This pull request removes local variables that were only used create a resource ID.

Fixes: #17036

Output from acceptance testing:

make acctests SERVICE='privatedns' TESTARGS='-run="TestAccDataSourcePrivateDNSZone_"'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/privatedns -run="TestAccDataSourcePrivateDNSZone_" -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourcePrivateDNSZone_basic
=== PAUSE TestAccDataSourcePrivateDNSZone_basic
=== RUN   TestAccDataSourcePrivateDNSZone_tags
=== PAUSE TestAccDataSourcePrivateDNSZone_tags
=== RUN   TestAccDataSourcePrivateDNSZone_withoutResourceGroupName
=== PAUSE TestAccDataSourcePrivateDNSZone_withoutResourceGroupName
=== CONT  TestAccDataSourcePrivateDNSZone_basic
=== CONT  TestAccDataSourcePrivateDNSZone_withoutResourceGroupName
=== CONT  TestAccDataSourcePrivateDNSZone_tags
--- PASS: TestAccDataSourcePrivateDNSZone_tags (236.25s)
--- PASS: TestAccDataSourcePrivateDNSZone_withoutResourceGroupName (266.74s)
--- PASS: TestAccDataSourcePrivateDNSZone_basic (270.78s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/privatedns    273.953s

[tombuildsstuff]

LGTM - thanks for this @owenfarrell

[github-actions]

This functionality has been released in v3.17.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.