Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_signalr_service - Add support for live_trace #17629

Merged
merged 2 commits into from
Jul 14, 2022
Merged

azurerm_signalr_service - Add support for live_trace #17629

merged 2 commits into from
Jul 14, 2022

Conversation

mbfrahry
Copy link
Member

No description provided.

katbyte
katbyte approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

katbyte
katbyte approved these changes Jul 14, 2022
View reviewed changes
internal/services/signalr/signalr_service_resource.go
MaxItems: 1,
Elem: &pluginsdk.Resource{
Schema: map[string]*schema.Schema{
"enabled": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we deprecate the live_trace_enabled bool above?

@mbfrahry mbfrahry merged commit 7847294 into main Jul 14, 2022
@mbfrahry mbfrahry deleted the f-signalr-livetrace branch July 14, 2022 17:56
mbfrahry added a commit that referenced this pull request Jul 14, 2022
@mbfrahry
Update changelog for #17629
5311b44
@mbfrahry mbfrahry added this to the v3.14.0 milestone Jul 14, 2022
@github-actions
Copy link

This functionality has been released in v3.14.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/signalr size/L
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mbfrahry @katbyte