Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kusto_cluster_resource - allowed_fqdns, allowed_ip_ranges, outbound_network_access_restricted #17581

Merged
merged 9 commits into from
Jul 20, 2022

Conversation

liuwuliuyun
Copy link
Contributor

  1. Add allowed_fqdn_list, allowed_ip_range_list and restrict_outbound_network_access to kusto cluster resource
  2. Update supported sku by https://docs.microsoft.com/en-us/azure/templates/microsoft.kusto/clusters?tabs=bicep#azuresku

@liuwuliuyun liuwuliuyun changed the title Kusto cluster properties update kusto_cluster_resource properties update Jul 11, 2022
@liuwuliuyun
Copy link
Contributor Author

GOROOT=D:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"D:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_complete_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"D:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_complete_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoCluster_complete\E$ #gosetup
=== RUN TestAccKustoCluster_complete
=== PAUSE TestAccKustoCluster_complete
=== CONT TestAccKustoCluster_complete
--- PASS: TestAccKustoCluster_complete (1287.03s)
PASS

Process finished with the exit code 0

@liuwuliuyun liuwuliuyun marked this pull request as draft July 11, 2022 08:11
@liuwuliuyun liuwuliuyun marked this pull request as ready for review July 11, 2022 08:42
@liuwuliuyun
Copy link
Contributor Author

GOROOT=D:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"D:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"D:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoCluster_basic\E$ #gosetup
=== RUN TestAccKustoCluster_basic
=== PAUSE TestAccKustoCluster_basic
=== CONT TestAccKustoCluster_basic
--- PASS: TestAccKustoCluster_basic (1099.87s)
PASS

Process finished with the exit code 0

internal/services/kusto/kusto_cluster_resource.go Outdated Show resolved Hide resolved
internal/services/kusto/kusto_cluster_resource.go Outdated Show resolved Hide resolved
internal/services/kusto/kusto_cluster_resource.go Outdated Show resolved Hide resolved
internal/services/kusto/kusto_cluster_resource.go Outdated Show resolved Hide resolved
@liuwuliuyun
Copy link
Contributor Author

Let me change according to review and resubmit in this week.

@liuwuliuyun
Copy link
Contributor Author

GOROOT=D:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"D:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"D:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoCluster_basic\E$ #gosetup
=== RUN TestAccKustoCluster_basic
=== PAUSE TestAccKustoCluster_basic
=== CONT TestAccKustoCluster_basic
--- PASS: TestAccKustoCluster_basic (1254.71s)
PASS

Process finished with the exit code 0

@liuwuliuyun
Copy link
Contributor Author

GOROOT=D:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"D:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_complete_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"D:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_complete_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoCluster_complete\E$ #gosetup
=== RUN TestAccKustoCluster_complete
=== PAUSE TestAccKustoCluster_complete
=== CONT TestAccKustoCluster_complete
--- PASS: TestAccKustoCluster_complete (1105.06s)
PASS

Process finished with the exit code 0

@liuwuliuyun liuwuliuyun requested a review from katbyte July 18, 2022 07:56
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧬

@katbyte katbyte changed the title kusto_cluster_resource properties update kusto_cluster_resource - allowed_fqdns, allowed_ip_ranges, outbound_network_access_restricted Jul 20, 2022
@katbyte katbyte merged commit 01029aa into hashicorp:main Jul 20, 2022
@github-actions github-actions bot added this to the v3.15.0 milestone Jul 20, 2022
katbyte added a commit that referenced this pull request Jul 20, 2022
@github-actions
Copy link

This functionality has been released in v3.15.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
@liuwuliuyun liuwuliuyun deleted the Kusto_cluster_properties_update branch September 26, 2022 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants