Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_lb_rule: backport of azure stack PR review comments #1754

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Aug 10, 2018

also adds protocol validation including the All option.

@katbyte katbyte added this to the 1.13.0 milestone Aug 10, 2018
@katbyte katbyte requested a review from a team August 10, 2018 23:39
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

screenshot 2018-08-13 at 14 15 35

@tombuildsstuff tombuildsstuff merged commit c4cbcb3 into master Aug 13, 2018
@tombuildsstuff tombuildsstuff deleted the lb-rule-stack_backports branch August 13, 2018 12:15
tombuildsstuff added a commit that referenced this pull request Aug 13, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants