-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing the property default_hostname
back to state for function apps
#17498
Conversation
Hi @xiaxyi , it looks like there are now conflicts with this MR due to recent merges. |
I'm happy to make the changes to fix this, but don't want to steal your thunder if you want to take care of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiaxyi - LGTM once the merge conflicts are fixed (and theres a test failure that would be good to fix up too)
------- Stdout: -------
=== RUN TestAccWindowsFunctionApp_addAppSettings
=== PAUSE TestAccWindowsFunctionApp_addAppSettings
=== CONT TestAccWindowsFunctionApp_addAppSettings
testcase.go:110: Step 3/6 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_windows_function_app.test will be updated in-place
~ resource "azurerm_windows_function_app" "test" {
id = "/subscriptions/*******/resourceGroups/acctestRG-LFA-220706171542149292/providers/Microsoft.Web/sites/acctest-WFA-220706171542149292"
name = "acctest-WFA-220706171542149292"
tags = {}
# (25 unchanged attributes hidden)
~ site_config {
# (23 unchanged attributes hidden)
+ application_stack {
+ node_version = "~14"
+ use_dotnet_isolated_runtime = false
}
}
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccWindowsFunctionApp_addAppSettings (378.66s)
FAIL
Thanks @katbyte , the test failure should have nothing to do with the property in this pr. I will check the test failures and submit a pr for the fix once I find the cause. |
Thanks for offering the help! I resolved the conflicts. :) |
This functionality has been released in v3.14.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
fixing issue:#16263