Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_certificate : fix azurerm_key_vault_certificate could not be recovered issue #17415

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Jun 28, 2022

Currently, after importing an existing certificate and then destroying azurerm_key_vault_certificate. It could not be recovered despite recover_soft_deleted_certificates is set to True.

In fact, Terraform should be able to recover the soft-deleted imported certificate. So, submitted this PR to fix issue #17168.

Test Results:

PASS: TestAccKeyVaultCertificate_disappears (379.61s)
PASS: TestAccKeyVaultCertificate_disappearsWhenParentKeyVaultDeleted (390.43s)
PASS: TestAccKeyVaultCertificate_unorderedKeyUsage (459.73s)
PASS: TestAccKeyVaultCertificate_basicExtendedKeyUsage (494.40s)
PASS: TestAccKeyVaultCertificate_basicGenerateSans (502.88s)
PASS: TestAccKeyVaultCertificate_basicGenerate (503.88s)
PASS: TestAccKeyVaultCertificate_emptyExtendedKeyUsage (504.42s)
PASS: TestAccKeyVaultCertificate_basicGenerateEllipticCurveAutoKeySize (505.54s)
PASS: TestAccKeyVaultCertificate_basicImportPFX (505.89s)
PASS: TestAccKeyVaultCertificate_basicGenerateTags (524.32s)
PASS: TestAccKeyVaultCertificate_purge (536.13s)
PASS: TestAccKeyVaultCertificate_basicGenerateUnknownIssuer (503.06s)
PASS: TestAccKeyVaultCertificate_basicGenerateEllipticCurve (480.16s)
PASS: TestAccKeyVaultCertificate_withExternalAccessPolicy (614.50s)
PASS: TestAccKeyVaultCertificate_requiresImport (511.59s)
PASS: TestAccKeyVaultCertificate_updateTags (560.92s)
PASS: TestAccKeyVaultCertificate_softDeleteRecovery (920.68s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai - LGTM 🎩

@katbyte katbyte merged commit ea73261 into hashicorp:main Jul 6, 2022
@github-actions github-actions bot added this to the v3.13.0 milestone Jul 6, 2022
katbyte added a commit that referenced this pull request Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v3.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
@sinbai sinbai deleted the keyvault/fix_issue_17168 branch March 28, 2024 03:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants