Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault data source: cache the vault_uri once read #17407

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 28, 2022

Mitigate #11059.

THe listing resources API won't be called if the keyVaultCache is populated. Currently, the cache is populated in following places (prior to calling the resource listing API):

  • When the key vault resource is created
  • When the key vault resource is read

The reports in #11059 are mostly happening when the depending key vault is a data source. This PR adds support for that use case.

In result, as long as users guarantee the correct dependency between key vault (either resource or data source) and the nested items, then the listing resource API is avoided.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.12.0 milestone Jun 29, 2022
@tombuildsstuff tombuildsstuff merged commit 0cb7cf1 into hashicorp:main Jun 29, 2022
tombuildsstuff added a commit that referenced this pull request Jun 29, 2022
@elongstreet88
Copy link

elongstreet88 commented Jun 29, 2022

Thanks @tombuildsstuff !
Is it possible to prioritize releasing 3.12.0 sooner than later for this fix in particular?
Assuming this resolves what we think its supposed to, our build performance will probably 10x back to what it used to.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants