Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: updating to v0.20220628.1190740 of github.com/hashicorp/go-azure-sdk #17399

Merged
merged 4 commits into from
Jun 28, 2022
Merged

dependencies: updating to v0.20220628.1190740 of github.com/hashicorp/go-azure-sdk #17399

merged 4 commits into from
Jun 28, 2022

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jun 27, 2022 •
edited
Loading

This PR updates to v0.20220628.1190740 of github.com/hashicorp/go-azure-sdk

Notably this version removes some of the Resource IDs which aren't actually configurable - notably TenantConfiguration within Portal - replacing them either with just a Uri or the parent Resource ID (and a URI Suffix) as appropriate.

@tombuildsstuff tombuildsstuff added this to the v3.12.0 milestone Jun 27, 2022
@tombuildsstuff tombuildsstuff requested a review from a team June 27, 2022 09:13
manicminer
manicminer approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍍

@tombuildsstuff tombuildsstuff changed the title dependencies: updating to v0.20220627.1082008 of github.com/hashicorp/go-azure-sdk dependencies: updating to v0.20220628.1190740 of github.com/hashicorp/go-azure-sdk Jun 28, 2022
@tombuildsstuff tombuildsstuff mentioned this pull request Jun 28, 2022
Merged
@tombuildsstuff tombuildsstuff force-pushed the deps/go-azure-sdk-v0.20220627.1082008 branch from bbad8ae to f1fcd70 Compare June 28, 2022 19:23
@github-actions github-actions bot added size/XL and removed size/L labels Jun 28, 2022
@tombuildsstuff
Copy link
Contributor Author

The only change from prior to the merge conflict was vendor related, this is fine to skip the other checks

@tombuildsstuff tombuildsstuff merged commit 2549564 into main Jun 28, 2022
@tombuildsstuff tombuildsstuff deleted the deps/go-azure-sdk-v0.20220627.1082008 branch June 28, 2022 19:52
tombuildsstuff added a commit that referenced this pull request Jun 28, 2022
@tombuildsstuff
updating to include #17399
5ed476a
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
dependencies service/portal size/XL
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @manicminer