Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes_cluster/node_pool- capacity_reservation_group_id #17395

Merged
merged 5 commits into from
Jul 6, 2022
Merged

kubernetes_cluster/node_pool- capacity_reservation_group_id #17395

merged 5 commits into from
Jul 6, 2022

Conversation

qiqingzhang
Copy link
Contributor

public pr for kubernetes_cluster/node_pool- capacity_reservation_group_id

@qiqingzhang qiqingzhang changed the title Feat kubernetes cluster supports capacity reservation group kubernetes_cluster/node_pool- capacity_reservation_group_id Jun 27, 2022
tombuildsstuff
tombuildsstuff suggested changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @heiazuo

Thanks for this PR, I've taken a look through and left a couple of comments inline but if we can fix those up then we can take another look.

Thanks!

website/docs/r/kubernetes_cluster.html.markdown Outdated
@@ -312,6 +312,8 @@ A `default_node_pool` block supports the following:

* `vm_size` - (Required) The size of the Virtual Machine, such as `Standard_DS2_v2`. Changing this forces a new resource to be created.

* `capacity_reservation_group_id` - (Optional) AKS will associate the specified agent pool with the Capacity Reservation Group. Changing this forces a new resource to be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presumably this should be:

Suggested change
* `capacity_reservation_group_id` - (Optional) AKS will associate the specified agent pool with the Capacity Reservation Group. Changing this forces a new resource to be created.
* `capacity_reservation_group_id` - (Optional) Specifies the ID of the Capacity Reservation Group within which this AKS Cluster should be created. Changing this forces a new resource to be created.

website/docs/r/kubernetes_cluster_node_pool.html.markdown Outdated
@@ -71,6 +71,8 @@ The following arguments are supported:

---

* `capacity_reservation_group_id` - (Optional) AKS will associate the specified agent pool with the Capacity Reservation Group. Changing this forces a new resource to be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `capacity_reservation_group_id` - (Optional) AKS will associate the specified agent pool with the Capacity Reservation Group. Changing this forces a new resource to be created.
* `capacity_reservation_group_id` - (Optional) Specifies the ID of the Capacity Reservation Group where this Node Pool should exist. Changing this forces a new resource to be created.

@qiqingzhang
Copy link
Contributor Author

Thanks @tombuildsstuff , documents updated, please take another look.

katbyte
katbyte approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦕

@katbyte katbyte merged commit 84e5363 into hashicorp:main Jul 6, 2022
@github-actions github-actions bot added this to the v3.13.0 milestone Jul 6, 2022
katbyte added a commit that referenced this pull request Jul 6, 2022
@katbyte
CHANGELOG #17395
77ff083
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v3.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/kubernetes-cluster size/L
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@qiqingzhang @tombuildsstuff @katbyte