Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update automation account to use go-azure-sdk #17347

Merged
merged 9 commits into from
Jul 29, 2022

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Jun 23, 2022

and update API version to 2021-06-22

add encryption in automation account property

remove embed sdk

use go-azure-sdk

use go-azure-sdk for automation
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @wuxu92

Thanks for this PR - I've taken a look through and left some comments inline, but this is off to a good start. If we can fix up the comments and switch the associated clients out then we should be able to take another look 👍

Thanks!

internal/services/automation/client/client.go Outdated Show resolved Hide resolved
internal/tags/expand.go Outdated Show resolved Hide resolved
internal/tags/flatten.go Outdated Show resolved Hide resolved
internal/services/automation/client/client.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff changed the title update automation account to use new pandora sdk update automation account to use go-azure-sdk Jun 27, 2022
@wuxu92
Copy link
Contributor Author

wuxu92 commented Jun 30, 2022

hey @wuxu92 Xu Wu FTE

Thanks for this PR - I've taken a look through and left some comments inline, but this is off to a good start. If we can fix up the comments and switch the associated clients out then we should be able to take another look 👍

Thanks!

@tombuildsstuff i have updated the pr.

@wuxu92
Copy link
Contributor Author

wuxu92 commented Jul 21, 2022

@tombuildsstuff hi is there any other should I do to make this pr be merged

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 - LGTM 🤖

@katbyte katbyte merged commit 23be676 into hashicorp:main Jul 29, 2022
katbyte added a commit that referenced this pull request Jul 29, 2022
@github-actions github-actions bot added this to the v3.16.0 milestone Jul 29, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

This functionality has been released in v3.16.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants