-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update automation account to use go-azure-sdk #17347
Conversation
add encryption in automation account property remove embed sdk use go-azure-sdk use go-azure-sdk for automation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @wuxu92
Thanks for this PR - I've taken a look through and left some comments inline, but this is off to a good start. If we can fix up the comments and switch the associated clients out then we should be able to take another look 👍
Thanks!
@tombuildsstuff i have updated the pr. |
@tombuildsstuff hi is there any other should I do to make this pr be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wuxu92 - LGTM 🤖
This functionality has been released in v3.16.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
and update API version to 2021-06-22