New Data Source/Resource: azurerm_cdn_frontdoor_profile
#17061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
force-pushed
the
f/cdn-frontdoor-core
branch
from
5d0b53c to
915e1ce
Compare
mbfrahry
approved these changes
Jun 1, 2022
internal/services/cdn/cdn_frontdoor_profile_data_source_test.go
Outdated
Show resolved
Hide resolved
Splitting out from #16671 Co-authored-by: Jeffrey Cline <[email protected]>
Co-authored-by: Jeffrey Cline <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
tombuildsstuff
force-pushed
the
f/cdn-frontdoor-core
branch
from
bed7de0 to
0f66652
Compare
|
|
|
This functionality has been released in v3.9.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having spent a decent chunk of time trying to review #16671, I've come to the conclusion that it's too big to review in it's current form - so I'll be pulling this apart and fixing it up at the same time.
This PR splits out the
azurerm_cdn_frontdoor_profileResource and adds a matching Data Source, since this is likely to be commonly references. The primary difference between this resource in this PR and in #16671 is thatsku_nameis now required andcdn_frontdoor_id(which is a UUID) is now namedresource_guid(which matches the naming of this field in other resources).Other PR's will build on this - as such this includes all of the SDK clients for simplicity - however those'll follow once this is in.