Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_cassandra_cluster - support new properties #16799

Merged
merged 12 commits into from
Jun 8, 2022

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented May 16, 2022

This PR is to support new properties authentication_method, client_certificate, external_gossip_certificate, external_seed_node, identity, repair_enabled and version.

--- PASS: TestAccCassandraSequential/cluster/complete (873.82s)
--- PASS: TestAccCassandraSequential/cluster/update (1067.56s)
--- PASS: TestAccCassandraSequential/cluster/requiresImport (852.31s)
--- PASS: TestAccCassandraSequential/cluster/basic (830.39s)

@neil-yechenwei neil-yechenwei changed the title [Draft] azurerm_cosmosdb_cassandra_cluster - support new properties azurerm_cosmosdb_cassandra_cluster - support new properties May 18, 2022
@neil-yechenwei neil-yechenwei changed the title azurerm_cosmosdb_cassandra_cluster - support new properties [Draft] azurerm_cosmosdb_cassandra_cluster - support new properties May 18, 2022
@neil-yechenwei neil-yechenwei changed the title [Draft] azurerm_cosmosdb_cassandra_cluster - support new properties azurerm_cosmosdb_cassandra_cluster - support new properties May 20, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - comments left inline

website/docs/r/cosmosdb_cassandra_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cosmosdb_cassandra_cluster.html.markdown Outdated Show resolved Hide resolved
@neil-yechenwei
Copy link
Contributor Author

@katbyte , thanks for your comments. I've updated code. Please take another look. Thanks in advance.

@neil-yechenwei neil-yechenwei requested a review from katbyte May 27, 2022 05:55
neil-yechenwei added 2 commits May 27, 2022 14:00
@katbyte
Copy link
Collaborator

katbyte commented Jun 2, 2022

Lots of test failures

------- Stdout: -------
=== RUN   TestAccCassandraSequential
=== RUN   TestAccCassandraSequential/cluster
=== RUN   TestAccCassandraSequential/cluster/update
    testcase.go:117: Step 1/4 error: Error running apply: exit status 1
        
        Error: waiting on create for "Cassandra Cluster: (Name \"acctca-mi-cluster-220601014336782446\" / Resource Group \"acctest-ca-220601014336782446\")": Code="InternalServerError" Message="The resource failed to be created because of an internal configuration error: Conflict. Please file a support ticket.\r\nActivityId: c7938082-4962-45e2-bd33-c740f8d97fb1, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0"
        
          with azurerm_cosmosdb_cassandra_cluster.test,
          on terraform_plugin_test.tf line 37, in resource "azurerm_cosmosdb_cassandra_cluster" "test":
          37: resource "azurerm_cosmosdb_cassandra_cluster" "test" {
        
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Subnet: (Name "acctsub-220601014336782446" / Virtual Network Name "acctvn-220601014336782446" / Resource Group "acctest-ca-220601014336782446"): network.SubnetsClient#Delete: Failure sending request: StatusCode=500 -- Original Error: Code="GatewayAuthenticationFailed" Message="Gateway authentication failed for 'Microsoft.Network'. Diagnostic information: timestamp '20220601T020647Z', tracking id '1dc5f9b6-41cd-45bb-a0a3-1227b19eb501', request correlation id 'fc6549e2-2be8-9183-769a-0aab9e829f17'."
        
=== RUN   TestAccCassandraSequential/cluster/requiresImport
=== RUN   TestAccCassandraSequential/cluster/basic
    testcase.go:117: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating/updating Virtual Network: (Name "acctvn-220601022444882934" / Resource Group "acctest-ca-220601022444882934"): network.VirtualNetworksClient#CreateOrUpdate: Failure sending request: StatusCode=500 -- Original Error: Code="GatewayAuthenticationFailed" Message="Gateway authentication failed for 'Microsoft.Network'. Diagnostic information: timestamp '20220601T023254Z', tracking id '2c9443e0-5931-47a7-be87-4250a1ba8568', request correlation id 'fc6549e2-2be8-9183-769a-0aab9e829f17'."
        
          with azurerm_virtual_network.test,
          on terraform_plugin_test.tf line 12, in resource "azurerm_virtual_network" "test":
          12: resource "azurerm_virtual_network" "test" {
        
=== RUN   TestAccCassandraSequential/cluster/complete
    testcase.go:117: Step 1/2 error: Error running apply: exit status 1
        

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jun 6, 2022

@katbyte , maybe it's just your test environment issue. All TCs passed on my local and Teamcity.

The test result on my local:
--- PASS: TestAccCassandraSequential/cluster/requiresImport (912.15s)
--- PASS: TestAccCassandraSequential/cluster/basic (866.22s)
--- PASS: TestAccCassandraSequential/cluster/complete (872.29s)
--- PASS: TestAccCassandraSequential/cluster/update (1116.11s)

The test result on Teamcity:
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌵

@katbyte katbyte merged commit 679caa9 into hashicorp:main Jun 8, 2022
@github-actions github-actions bot added this to the v3.10.0 milestone Jun 8, 2022
katbyte added a commit that referenced this pull request Jun 8, 2022
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants