-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_cosmosdb_cassandra_cluster - support new properties #16799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neil-yechenwei - comments left inline
@katbyte , thanks for your comments. I've updated code. Please take another look. Thanks in advance. |
Lots of test failures
|
@katbyte , maybe it's just your test environment issue. All TCs passed on my local and Teamcity. The test result on my local: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌵
This functionality has been released in v3.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR is to support new properties
authentication_method
,client_certificate
,external_gossip_certificate
,external_seed_node
,identity
,repair_enabled
andversion
.--- PASS: TestAccCassandraSequential/cluster/complete (873.82s)
--- PASS: TestAccCassandraSequential/cluster/update (1067.56s)
--- PASS: TestAccCassandraSequential/cluster/requiresImport (852.31s)
--- PASS: TestAccCassandraSequential/cluster/basic (830.39s)