Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new resource azurerm_spring_cloud_api_portal #16719

Merged
merged 4 commits into from
May 26, 2022
Merged

new resource azurerm_spring_cloud_api_portal #16719

merged 4 commits into from
May 26, 2022

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented May 10, 2022 •
edited
Loading

image

katbyte
katbyte requested changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failures:
image

website/docs/r/spring_cloud_api_portal.html.markdown Outdated Show resolved Hide resolved
@ms-henglu ms-henglu force-pushed the branch-220510-spring-cloud-api-portal branch from fd4adf7 to c28bcbe Compare May 13, 2022 04:04
@ms-henglu
Copy link
Contributor Author

@katbyte - I've fixed the testcases, and renamed the field, please take another look, thanks!
image

katbyte
katbyte approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 🍾

@katbyte katbyte merged commit c9c89ca into hashicorp:main May 26, 2022
katbyte added a commit that referenced this pull request May 26, 2022
@katbyte
CHANGELOG #16719
797691e
@github-actions github-actions bot added this to the v3.8.0 milestone May 26, 2022
@github-actions
Copy link

This functionality has been released in v3.8.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies documentation service/spring size/XL
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-henglu @katbyte