Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future.WaitForCompletion() -> future.WaitForCompletionRef() #1660

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jul 26, 2018

future.WaitForCompletion() was deprecated in the SDK in favor of future.WaitForCompletionRef()

@katbyte katbyte added this to the 1.12.0 milestone Jul 26, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Ignoring some transient test failures (due to subscription usage limits being hit) - the tests pass:

screenshot 2018-07-27 at 07 50 02

@tombuildsstuff tombuildsstuff merged commit 7f21ce6 into master Jul 27, 2018
@tombuildsstuff tombuildsstuff deleted the b-WaitForCompletionRef branch July 27, 2018 05:51
tombuildsstuff added a commit that referenced this pull request Jul 27, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants