Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management - Default hostname proxy configuration is no longer ignored #16524

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

xuzhang3
Copy link
Contributor

#16065 Default hostname proxy configuration should not be ignored.

AccTests:

=== RUN   TestAccApiManagement_basic
=== PAUSE TestAccApiManagement_basic
=== CONT  TestAccApiManagement_basic
--- PASS: TestAccApiManagement_basic (5167.18s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/apimanagement (4241.322s)
=== RUN   TestAccApiManagement_requiresImport
=== PAUSE TestAccApiManagement_requiresImport
=== CONT  TestAccApiManagement_requiresImport
--- PASS: TestAccApiManagement_requiresImport (8485.80s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/apimanagement 8488.355s

@xuzhang3 xuzhang3 changed the title Fix default hostname proxy configuration azurerm_api_management - Fix : Default hostname proxy configuration should not be ignored Apr 27, 2022
@nnnvvvcv
Copy link
Contributor

nnnvvvcv commented May 5, 2022

How can we get this merged?

@julieerle
Copy link
Contributor

Hey Terraform Azure RM provider team. Can this get a review? Either merged or closed with a comment as to why we cannot/do not want to implement?

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v3.10.0 milestone Jun 9, 2022
@mbfrahry mbfrahry changed the title azurerm_api_management - Fix : Default hostname proxy configuration should not be ignored azurerm_api_management - Default hostname proxy configuration is no longer ignored Jun 9, 2022
@mbfrahry mbfrahry merged commit acfb7a8 into hashicorp:main Jun 9, 2022
mbfrahry added a commit that referenced this pull request Jun 9, 2022
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@julieerle
Copy link
Contributor

WOW! Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2022
@xuzhang3 xuzhang3 deleted the fix/apim_default_hostname_proxy branch August 14, 2024 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants