Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_servicebus_namespace - sku can be updated to Basic/Standard without recreating the resource #16523

Merged
merged 2 commits into from
May 2, 2022

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Apr 24, 2022

The sku property shouldn't be defined as forcenew since the service supports sku update from basic to standard.

acc tests:

--- PASS: TestAccAzureRMServiceBusNamespace_updateSku (610.02s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicebus    611.142s

Fix GH issue:
#16463

@mbfrahry mbfrahry changed the title Fix servicebus namespace sku issue azurerm_servicebus_namespace - sku can be updated to Basic/Standard without recreating the resource May 2, 2022
@mbfrahry mbfrahry added this to the v3.5.0 milestone May 2, 2022
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 1e0c010 into hashicorp:main May 2, 2022
mbfrahry added a commit that referenced this pull request May 2, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

This functionality has been released in v3.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants