Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_resource_policy_remediation - Fix deletion failure due to canceling a completed remediation task #16478

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 21, 2022

Remediation task can only be canceled when it is in "Evaluating" status; Canceling a completed remediation task will cause 400 bad request.

I've tested locally by using the config from TestAccAzureRMResourcePolicyRemediation_basic. After provisioning, the remediation is in "Evaluating" state. Wait for a couple of minutes till its state changes to Completed, then sending the cancel request will raise 400 bad request, complaining that a completed remediation task can't be canceled.

Fix #16456

…anceling a completed remediation task

Remediation task can only be canceled when it is in "Evaluating" status; Canceling a completed remediation task will cause 400 bad request.
@github-actions github-actions bot added size/M and removed size/S labels Apr 21, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - LGTM 🌿

katbyte added a commit that referenced this pull request Apr 21, 2022
@catriona-m catriona-m merged commit 68e9da0 into hashicorp:main Apr 22, 2022
@github-actions github-actions bot added this to the v3.4.0 milestone Apr 22, 2022
catriona-m added a commit that referenced this pull request Apr 22, 2022
@github-actions
Copy link

This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_subscription_policy_remediation attempts deletion after completion and fails
3 participants