Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access_tier attribute to storage_share #16462

Merged
merged 4 commits into from
May 6, 2022
Merged

Add access_tier attribute to storage_share #16462

merged 4 commits into from
May 6, 2022

Conversation

koikonom
Copy link
Contributor

@koikonom koikonom commented Apr 20, 2022 •
edited
Loading

No description provided.

@koikonom koikonom requested a review from a team April 20, 2022 08:42
@koikonom koikonom marked this pull request as draft April 20, 2022 09:31
@koikonom koikonom force-pushed the giovanni_upgrade branch from 174f4b7 to b6a541f Compare May 3, 2022 12:46
@koikonom koikonom marked this pull request as ready for review May 3, 2022 12:47
tombuildsstuff
tombuildsstuff suggested changes May 5, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments inline but this otherwise LGTM 👍

internal/services/storage/storage_share_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_share_resource_test.go Outdated Show resolved Hide resolved
website/docs/d/storage_share.html.markdown Outdated Show resolved Hide resolved
tombuildsstuff
tombuildsstuff approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.6.0 milestone May 6, 2022
@koikonom koikonom merged commit 2445599 into main May 6, 2022
@koikonom koikonom deleted the giovanni_upgrade branch May 6, 2022 09:39
koikonom pushed a commit that referenced this pull request May 6, 2022
Update Changelog for #16462
2bda105
@csorzi csorzi mentioned this pull request May 16, 2022
Closed
@github-actions
Copy link

This functionality has been released in v3.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

wernerfred
wernerfred reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff @koikonom shouldn't the website/docs/d/storage_share.html.markdown (datasource) go into website/docs/r/storage_share.html.markdown (resources)?

@jkodroff jkodroff mentioned this pull request May 19, 2022
Closed
1 task
@mbfrahry mbfrahry mentioned this pull request May 20, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wernerfred wernerfred wernerfred left review comments

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug documentation enhancement service/storage size/M
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@koikonom @tombuildsstuff @wernerfred