New resource - azurerm_sentinel_data_connector_aws_s3
#16440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
requested changes
Apr 21, 2022
internal/services/sentinel/sentinel_data_connector_aws_s3_resource.go
Outdated
Show resolved
Hide resolved
internal/services/sentinel/sentinel_data_connector_aws_s3_resource.go
Outdated
Show resolved
Hide resolved
|
@katbyte Thank you for the comments! I've fixed all of them. Please take another look! |
|
This functionality has been released in v3.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new sentinel data connector type: AWS S3. Checkout https://docs.microsoft.com/en-us/azure/sentinel/connect-aws for details.
As this resource needs setup of several AWS resources as a precondition, this PR didn't include an AccTest for it. I've locally tested the functionalities: CRUD and plan, which behaves as expected.