Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_linked_service_azure_blob_storage: Support service_principal_linked_key_vault_key property #16414

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

favoretti
Copy link
Collaborator

Adds support for passing SP key as a linked KV reference for ADF blob
storage linked service.

$ TF_ACC=1 go test -v ./internal/services/datafactory -timeout=1000m -run='TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key'
=== RUN   TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key
=== PAUSE TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key
=== CONT  TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key
--- PASS: TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key (360.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/datafactory	361.646s

KV reference

Adds support for passing SP key as a linked KV reference for ADF blob
storage linked service.

```
$ TF_ACC=1 go test -v ./internal/services/datafactory -timeout=1000m -run='TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key'
=== RUN   TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key
=== PAUSE TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key
=== CONT  TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key
--- PASS: TestAccDataFactoryLinkedServiceAzureBlobStorage_service_endpoint_with_key_vault_service_principal_key (360.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/datafactory	361.646s
```
@favoretti
Copy link
Collaborator Author

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti ! LGTM 🦀

@katbyte katbyte merged commit d264a60 into hashicorp:main Apr 21, 2022
@github-actions github-actions bot added this to the v3.3.0 milestone Apr 21, 2022
@katbyte katbyte changed the title azurerm_data_factory_linked_service_azure_blob_storage: Support SP key KV reference azurerm_data_factory_linked_service_azure_blob_storage: Support service_principal_linked_key_vault_key property Apr 21, 2022
katbyte added a commit that referenced this pull request Apr 21, 2022
@github-actions
Copy link

This functionality has been released in v3.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants