Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for columns_to_remove of azurerm_stream_analytics_output_table #16389

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Add support for columns_to_remove of azurerm_stream_analytics_output_table #16389

merged 2 commits into from
Apr 21, 2022

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Apr 14, 2022 •
edited
Loading

This PR is to support new property columns_to_remove of azurerm_stream_analytics_output_table.

--- PASS: TestAccStreamAnalyticsOutputTable_basic (273.80s)
--- PASS: TestAccStreamAnalyticsOutputTable_requiresImport (304.54s)
--- PASS: TestAccStreamAnalyticsOutputTable_update (354.57s)
--- PASS: TestAccStreamAnalyticsOutputTable_columnsToRemove (633.89s)

stephybun
stephybun requested changes Apr 20, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei, I have one question and a suggestion. Otherwise this looks mostly good to me.

internal/services/streamanalytics/stream_analytics_output_table_resource.go Outdated Show resolved Hide resolved
internal/services/streamanalytics/stream_analytics_output_table_resource.go Outdated Show resolved Hide resolved
@neil-yechenwei
Copy link
Contributor Author

@stephybun , thanks for your comments. I've updated code. Please take another look. Thanks.

stephybun
stephybun approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei, LGTM 🍰

@stephybun stephybun merged commit cfe8a43 into hashicorp:main Apr 21, 2022
@github-actions github-actions bot added this to the v3.3.0 milestone Apr 21, 2022
stephybun added a commit that referenced this pull request Apr 21, 2022
@stephybun
Update for #16389
1568f7e
@github-actions
Copy link

This functionality has been released in v3.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/stream-analytics size/M
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neil-yechenwei @stephybun