Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_container_registry_agent_pool #16258

Merged

Conversation

favoretti
Copy link
Collaborator

New version of #14790

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - overall looks good aside from one test failure which i think my inline comment should fix:

------- Stdout: -------
=== RUN   TestAccContainerRegistryAgentPool_complete
=== PAUSE TestAccContainerRegistryAgentPool_complete
=== CONT  TestAccContainerRegistryAgentPool_complete
    testcase.go:110: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 29, in resource "azurerm_subnet" "test":
          29:   address_prefix       = "10.0.2.0/24"
        
        An argument named "address_prefix" is not expected here. Did you mean
        "address_prefixes"?
--- FAIL: TestAccContainerRegistryAgentPool_complete (3.05s)
FAIL

@katbyte katbyte merged commit d512a3f into hashicorp:main Apr 6, 2022
@github-actions github-actions bot added this to the v3.1.0 milestone Apr 6, 2022
katbyte added a commit that referenced this pull request Apr 7, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants