Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_mssql_database - support for property ledger_enabled #16214

Merged
merged 4 commits into from
Apr 6, 2022
Merged

azurerm_mssql_database - support for property ledger_enabled #16214

merged 4 commits into from
Apr 6, 2022

Conversation

catriona-m
Copy link
Member

fixes #16154

@catriona-m catriona-m requested a review from a team April 1, 2022 10:23
mbfrahry
mbfrahry approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I did have some questions to look into before merging!

internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_database_resource.go
"ledger_enabled": {
Type: pluginsdk.TypeBool,
Optional: true,
Computed: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is defaulted to false in the api when we don't specify it so we should be able to do that here unless you saw something different!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry! I did try adding the default here, but this needs to be computed to cover the case where ledger_enabled is set to true and then imported.

internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
@catriona-m catriona-m merged commit 184afa5 into main Apr 6, 2022
@catriona-m catriona-m deleted the cm/mssql_ledger_on branch April 6, 2022 16:28
@github-actions github-actions bot added this to the v3.1.0 milestone Apr 6, 2022
catriona-m added a commit that referenced this pull request Apr 6, 2022
@catriona-m
Update changelog for #16214
f26504e
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation service/mssql Microsoft SQL Server size/S
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Support for ledger_on parameter in azurerm_mssql_database
2 participants
@catriona-m @mbfrahry