Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_windows_web_app and azurerm_windows_web_app_slot - fix docker windowsfxversion string clobbering #16192

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

jackofallops
Copy link
Member

  • azurerm_windows_web_app - fix docker windowsFXVersion when docker_container_registry is specified
  • azurerm_windows_web_app_slot - fix docker windowsFXVersion when docker_container_registry is specified

fixes #16157

@jackofallops jackofallops added this to the v3.1.0 milestone Mar 31, 2022
@jackofallops jackofallops requested a review from a team March 31, 2022 14:56
@jackofallops jackofallops self-assigned this Mar 31, 2022
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackofallops jackofallops merged commit 4fab12d into main Apr 5, 2022
@jackofallops jackofallops deleted the b/windows-web-app-docker-fxbug branch April 5, 2022 07:43
jackofallops added a commit that referenced this pull request Apr 5, 2022
catriona-m pushed a commit that referenced this pull request Apr 6, 2022
catriona-m pushed a commit that referenced this pull request Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_windows_web_app_slot create a malformed WindowsFxVersion
2 participants